nursery_cancel doesn't seem to create cyclic garbage on 3.12 anymore #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2829 +/- ##
==========================================
- Coverage 99.16% 99.16% -0.01%
==========================================
Files 115 115
Lines 17483 17482 -1
Branches 3115 3113 -2
==========================================
- Hits 17337 17336 -1
Misses 101 101
Partials 45 45
|
CoolCat467
approved these changes
Oct 23, 2023
|
FYI I did some bisecting and this turns out not to be due to an upstream change but instead due to a3d9d25 being merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least if I'm reading pytest output correctly.
Fixes #2646 and presumably python/cpython#100964 can be closed as well.